test(site/src/pages/AgentsPage): remove assertion-only story play functions - #29017
Merged
Merged
Conversation
DanielleMaywood
force-pushed
the
remove-assertion-only-play-functions
branch
from
September 7, 2026 08:11
722b91b to
d1f5fe3
Compare
DanielleMaywood
force-pushed
the
remove-assertion-only-play-functions
branch
from
September 7, 2026 09:52
d1f5fe3 to
264314b
Compare
DanielleMaywood
force-pushed
the
remove-assertion-only-play-functions
branch
from
September 8, 2026 15:27
264314b to
2555ae6
Compare
…ctions Storybook is visual regression only in this repository: the storybook CI job runs pixel-storybook, which loads each story, runs its play function, waits for the DOM to settle, and screenshots it. A play function that only asserts visible state duplicates what the screenshot already captures, and Pixel fails the capture only when a play throws. Remove the play functions whose bodies are purely queries and assertions on visible state across the AgentsPage scope (320 stories in 44 files). Keep every play that drives state the screenshot needs: menu opens, expand clicks, hovers, typing, and forced-visibility setup all survive, and the plays for pixel-excluded stories are untouched so their behavior coverage is not lost. Stories whose play was their only property now render as plain visual states. Behavior assertions that Pixel cannot see (callbacks, attributes, storage, focus) are intentionally not converted here; follow-up PRs move them into Vitest.
DanielleMaywood
force-pushed
the
remove-assertion-only-play-functions
branch
from
September 9, 2026 08:19
2555ae6 to
18db5c2
Compare
DanielleMaywood
marked this pull request as ready for review
September 9, 2026 09:01
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
jakehwll
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Storybook is visual regression only in this repository: the storybook CI job runs pixel-storybook, which loads each story, runs its play function, waits for the DOM to settle, and screenshots it. A play function that only asserts visible state duplicates what the screenshot already captures, and Pixel fails the capture only when a play throws.
This removes the play functions whose bodies are purely queries and assertions on visible state across the AgentsPage scope: 320 stories in 44 files.
What is intentionally kept:
Coverage impact of the removal was checked one by one. The removed plays contained three assertions with no visual counterpart:
ProviderRequiresUserApiKey's Settings linkhrefis asserted identically inModelSelectorHelp.test.tsx.AdvisorTool.Running'saria-expanded="true"is asserted by the survivingSuccessfulAdviceandLongAdviceLongQuestionstories.HiddenAssistantPlaceholderDoesNotRender's row-suppression behavior is covered bymessageHelpers.test.ts"hides assistant messages whose execute tool renders nothing".None of these removed plays asserted callbacks, storage, or real browser behavior that Pixel cannot see; nothing non-visual was lost, so no conversion was needed. Per the FE1 contract in #29016, what the DOM renders belongs to the screenshot, and tests assert the non-visual outcome of an interaction.
Generated by Coder Agents on behalf of @DanielleMaywood.