fix(site/src/pages/AgentsPage): use outlined empty state and kebab menu for personal skills - #28560
Merged
Merged
Conversation
…nu for personal skills
…l text with table conventions
tracyjohnsonux
marked this pull request as ready for review
August 25, 2026 16:58
ibetitsmike
approved these changes
Aug 25, 2026
Collaborator
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
… error and row menu usable during download
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Polishes the
/agents/settings/personal-skillspage to match the table patterns used elsewhere (e.g. the AI Gateway keys page):TableLoaderwhile loading, aTableEmptywith a Retry CTA on error (with theErrorAlertabove), and aTableEmptywith an Add skill CTA when there are no skills.EllipsisVertical) dropdown menu, following the pattern inCustomRolesPageView. The trigger shows a spinner and disables while a download is in flight, and the Actions column header is now screen-reader only.Storybook interaction coverage:
RowMenuActionsopens the kebab and exercises Download, Edit, and Delete;DownloadingSkillasserts the disabled trigger.Review notes
Self-audited the diff against the FE1-FE10 rules in
.claude/docs/FRONTEND_PATTERNS.md: all rules pass. All 22 stories pass locally, along with Biome andtsc.Generated by Coder Agents on behalf of @tracyjohnsonux.