fix(site/src/pages/AgentsPage): add organization filter to compaction settings (otherwise selection broken) - #28559
Merged
Merged
Conversation
…o compaction settings
…ization filter" This reverts commit 4cb0692.
tracyjohnsonux
changed the title
…paction org filter
…ring threshold save
tracyjohnsonux
marked this pull request as ready for review
August 25, 2026 18:28
ibetitsmike
reviewed
Aug 26, 2026
ibetitsmike
left a comment
ibetitsmike
left a comment
Collaborator
There was a problem hiding this comment.
Disclosure: This review was researched and written by Xum, an AI coding agent, acting for @ibetitsmike.
Ran the repo frontend-review audit (FE1-FE10) over the merge-base diff (5 files under site/src/).
FE1 PASS play fns drive org switching, single-org filter hiding, and scoped save/restore
FE2 PASS generated Organization/ChatModel types; no any / casts / non-null assertions
FE3 PASS reuses OrganizationAutocomplete + getOrganizationLabel
FE4 PASS draft-isolation comments explain why, not what
FE5 PASS loading / error (incl. partial model-load) / empty handled; drafts survive org switches
FE6 PASS inputs keep provider/model/org context in accessible names
FE7 PASS standard react-query patterns; no hardcoded keys or direct API calls
FE8 PASS no effects added; active org + visible models derived in render
FE9 PASS MockDefaultOrganization / MockOrganization2 / MockChatModel reused
FE10 PASS findByRole / findByLabelText / getByText only
Notes:
- The org filter auto-hides when enabled models span a single organization.
- Switching the filter does not discard unsubmitted drafts or save hidden rows.
- Removing the visual org subtitle keeps the org name in accessible labels for screen readers; badge sizing sm -> md matches agent settings standards.
Verdict: clean per the FE rule contract; no blocking findings. CI green at e39671ae.
ibetitsmike
approved these changes
Aug 26, 2026
tracyjohnsonux
enabled auto-merge (squash)
August 26, 2026 17:47
tracyjohnsonux
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an organization picker above the compaction thresholds table on
/agents/settings/compaction, matching the organization dropdowns in the agents admin area (OrganizationAutocomplete, as used by the Models and MCP Servers pages). The picker only appears when enabled models span more than one organization, defaults to the default organization, and the table shows the selected organization's models. Save tracking still covers all models so an edited row hidden by the picker is not dropped.Also removes the organization name text under each model badge (the organization remains in the accessible labels to disambiguate duplicate model names) and changes the model badge size from
smtomd.This PR was generated by Coder Agents on behalf of @tracyjohnsonux.