fix(site/src/components/Badge): bump sm badges from text-2xs to text-xs - #28517
Closed
tracyjohnsonux wants to merge 1 commit into
Closed
fix(site/src/components/Badge): bump sm badges from text-2xs to text-xs#28517tracyjohnsonux wants to merge 1 commit into
tracyjohnsonux wants to merge 1 commit into
Conversation
untra
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Badge size="sm"renders text attext-2xs(10px). This was tolerable while MUI'sCssBaselineapplied a 14px body typography baseline, but since the MUI/Emotion removal (#27821) dropped that baseline, inherited text defaults to 16px and the 10px badges read as broken — e.g. the Type/Tags chips on the provisioner jobs page and the pills on the AI Gateway sessions pages.Changes
smsize:text-2xs(10px) →text-xs(12px).smheight:h-5.5(22px) →h-6(24px) so the 1remtext-xsline-height pluspy-1fits without overflowing the fixed height.xs(10px, used for genuinely dense contexts) andmdare unchanged. This affects everysize="sm"consumer by design — that is the point: it fixes all of the too-small chips in one place (provisioner type/tags, network call pills, etc.).Notes for reviewers
smsizing came from the Figma-alignment pass in fix: resolve<Badge />incorrect sizes #22539 (and predates it); flagging for design sign-off since this intentionally diverges from that spec in response to the post-refactor: remove MUI and Emotion #27821 typography baseline change.smbadges.Related: #28477 (token badge icon sizing/cleanup; its font-size aspect is superseded by this PR).