fix(site/src): give built-in emoji avatars a consistent inset - #28492
Merged
Conversation
tracyjohnsonux
marked this pull request as ready for review
August 25, 2026 04:58
tracyjohnsonux
changed the title
jakehwll
reviewed
Aug 25, 2026
Comment on lines
+56
to
+68
| size: "lg", | ||
| variant: "emoji", | ||
| className: "p-[calc(var(--avatar-lg)*0.2)]", | ||
| }, | ||
| { | ||
| size: "md", | ||
| variant: "emoji", | ||
| className: "p-[calc(var(--avatar-default)*0.2)]", | ||
| }, | ||
| { | ||
| size: "sm", | ||
| variant: "emoji", | ||
| className: "p-[calc(var(--avatar-sm)*0.2)]", |
Contributor
There was a problem hiding this comment.
I think these classNamees can be probably fine with a style: {}. I'll have an agent follow up but other than that this is easy 🙂
jakehwll
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Built-in emoji avatars (
/emojis/*.png) rendered inconsistently: edge to edge on user avatars (users table, organization members, group member lists, exposed by the avatarIconFieldfrom #26652), and with the tighter icon padding on pages that passvariant="icon"such as workspace proxies.Avatargains anemojivariant with a proportional inset of 20% per side, expressed ascalc(var(--avatar-*) * 0.2)so it tracks the avatar size tokens. Built-in emoji sources, detected by the sharedisBuiltInEmojiUrlhelper (site/src/utils/emojis.ts, which also generates the URLs forIconField), always resolve to it, including at call sites that passvariant="icon"for data-dependent sources; the override is documented onAvatarProps. Non-emoji icon avatars are unchanged. AddedBuiltInEmoji{Lg,Md,Sm}Sizestories.Investigation notes
<Avatar />and<AvatarCard />#24527) was style-mechanics only (cssprop tostyle,CSSObjecttoCSSProperties).variant="icon"(compound variants inavatarVariants). Group rows/headers and workspace proxies pass it; user avatar call sites (UsersTable,OrganizationMembersTable,GroupMembersPage,GroupsPageViewmember column) do not./emojis/<unified>.pngURLs, exposing the missing inset.md/sm(12.5%) thanlg(20%), which made default-size emojis look oversized, so emojis get their own size-keyed inset instead of reusing the icon variant.🤖 Generated by Coder Agents on behalf of @tracyjohnsonux