fix: move organization model overrides from Models to Coder Agents settings - #28473
Conversation
Docs previewCheck off each page once it's been reviewed. If a page changes in a later push, its checkbox clears automatically so it gets a fresh look. Pages not yet wired into the docs navigation aren't listed here. |
…ttings The Defaults & overrides tab under AI Settings > Models mixed agent override controls into the reusable model catalog and gated them behind the Models layout, while the Coder Agents page was gated wholesale by editDeploymentConfig and blocked organization model administrators. Relocate the organization override controls (General, Explore, title generation, compaction, and Advisor) into an Organization settings section on the Coder Agents page with an organization picker, and keep deployment-wide controls in a separate Deployment settings section visible only with editDeploymentConfig. The page and sidebar entry are now accessible with either deployment or organization model access. The legacy /ai/settings/models/defaults route redirects to /ai/settings/coder-agents preserving query parameters. The Models page drops its now-single tab UI and the unused defaults path helpers.
0d75682 to
034a2a2
Compare
Documentation CheckThis PR removes the Defaults & overrides tab under AI Settings > Models and relocates the organization-scoped admin override controls to an Organization settings section on AI Settings > Coder Agents. Two docs still point at the old location and are now inaccurate. (The PR body notes docs are intentionally deferred to a follow-up; flagging here for tracking.) Updates Needed
Automated review via Coder Agents |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 034a2a21ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
Relocates the organization-scoped Coder Agents model override controls from the Defaults & overrides tab under AI Settings > Models into an Organization settings section on AI Settings > Coder Agents. Models remains the home for reusable model definitions, provider availability, default designation, and ACLs; Coder Agents now owns all agent-specific model/reasoning override controls. The backend organization scoping from #28442 is unchanged.
Changes
chat-advisorexperiment) model/reasoning overrides, with an organization picker when more than one accessible organization exists.editDeploymentConfig.editDeploymentConfigor organization chat model access. Organization mutations requireeditChatModelConfigson the selected organization; otherwise controls render read-only. Organization discovery, selected-organization permissions, and deployment queries fail independently.DefaultsPagecomponents move toCoderAgentsPage/OrganizationAgentSettings*./ai/settings/models/defaultsredirects to/ai/settings/coder-agents, preservingorgand other query parameters.docs/ai-coder/agents/models.mdanddocs/ai-coder/agents/platform-controls/advisor.md.Testing
ModelDefaultsRedirect,organizationModels): 9 passing.pnpm check, fullpnpm lint(Biome, tsc, circular deps, React compiler, knip),pnpm format.