fix: delete DateTimeRangeFilter and unify on the picker's time range type - #28427
Merged
Conversation
…r's time range type
tracyjohnsonux
marked this pull request as ready for review
August 20, 2026 23:29
jeremyruppel
approved these changes
Aug 20, 2026
tracyjohnsonux
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the deduplication agreed in #28392 (review): now that
DateTimeRangePickerhas replaced the text-expressionDateTimeRangeFilteron the AI Gateway sessions page, the old component and itsTimeRangetype are deleted, leaving a single time-range value shape.site/src/components/DateTimeRangeFilter/(component, stories,timeRange.tshelpers, tests); nothing imported it except the sessions page type alias.ListSessionsPage/timeRange.tsnow use neutral{start, end}naming derived from the picker'sDateTimeRangeValue(type TimeRange = Pick<DateTimeRangeValue, "start" | "end">), removing thestartedAfter/startedBeforefield mapping the page previously did by hand.No behavior changes: the query-string serialization (
started_after/started_beforeRFC 3339 params) is untouched, and all existing unit tests pass with only field renames.Generated by Coder Agents on behalf of @tracyjohnsonux.