Skip to content

feat(site): gate appearance settings behind Premium paywall - #27948

Merged
jakehwll merged 2 commits into
mainfrom
jakehwll/appearance-settings-paywall
Aug 17, 2026
Merged

feat(site): gate appearance settings behind Premium paywall#27948
jakehwll merged 2 commits into
mainfrom
jakehwll/appearance-settings-paywall

Conversation

@jakehwll

@jakehwll jakehwll commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Appearance settings previously showed a Premium paywall badge above still-visible branding and announcement banner forms.

When appearance is not entitled, show only the shared Premium paywall. When entitled, show the branding form and announcement banners.

Appearance settings previously showed a Premium paywall badge above still-visible branding and announcement banner forms.

When appearance is not entitled, show only the shared Premium paywall. When entitled, show the branding form and announcement banners.
@jakehwll
jakehwll requested a review from untra August 9, 2026 04:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 37f0beaa9c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

}
/>
<AnnouncementBannerSettings
isEntitled

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove the now-unreachable entitlement branch

This component is now mounted only inside the parent’s isEntitled branch, and this call always passes true; repo-wide search confirms there are no other callers. Consequently, every !isEntitled path in AnnouncementBannerSettings, including its license guidance and disabled table state, is unreachable and leaves a misleading prop/API behind. Remove the prop and simplify those dead branches in accordance with the canonical FE3 contract.

AGENTS.md reference: site/AGENTS.md:L5-L7

Useful? React with 👍 / 👎.

@jakehwll
jakehwll enabled auto-merge (squash) August 17, 2026 07:06
@jakehwll
jakehwll merged commit 41d2ece into main Aug 17, 2026
27 checks passed
@jakehwll
jakehwll deleted the jakehwll/appearance-settings-paywall branch August 17, 2026 07:19
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants