refactor(site): show audit log retention and Premium paywall on observability settings - #27947
Conversation
…vability settings The Audit Logging section on deployment observability settings only showed a badge or an info alert, with no actual setting underneath. When audit logging is entitled, show the Audit Logs Retention option. When it is not, show the shared Premium paywall instead of the inline alert.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39bd83f41b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <OptionsTable | ||
| options={options.filter((o) => o.name === "Audit Logs Retention")} | ||
| /> |
There was a problem hiding this comment.
When audit logging is enabled, this newly added OptionsTable renders alongside the existing Monitoring table, but OptionsTable emits a <table> with neither an aria-label nor a caption. Both tables therefore have the same "Option" and "Value" headers and are indistinguishable to screen-reader users; extend OptionsTable to accept an accessible name and label both instances.
AGENTS.md reference: site/AGENTS.md:L191-L195
Useful? React with 👍 / 👎.
Reconcile with main's PaywallPremium refactor: drop the removed documentationLink prop and update ObservabilitySettingsPageView stories to assert the refactored Premium paywall DOM.
2 participants
The Audit Logging section on deployment observability settings only showed a badge or an info alert, with no actual setting underneath.
When audit logging is entitled, show the Audit Logs Retention option. When it is not, show the shared Premium paywall instead of the inline alert.