refactor(site): replace MUI Stack, TextField, and Link with shared components - #27817
Conversation
…mponents Continue the MUI → Tailwind/shadcn migration across a few auth and settings surfaces. - Create token form: MUI `TextField`/`MenuItem` → `FormField`, `Select`, and `Input` (drops Emotion for section min-width) - Create organization form: `TextField` → `FormField` / `Textarea`, matching the organization info form - SSO security section and external auth: MUI `Link`/`TextField` → shared `Link`, `Input`, and `Label` - Permission and IdP pill lists: MUI `Stack` → `flex flex-row gap-2` - Minor link layout polish on Git device auth / external auth pages
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 320cd40d7c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <Select | ||
| value={String(lifetimeDays)} | ||
| onValueChange={setLifetimeDays} | ||
| > | ||
| {customLifetimeDay.label} | ||
| </MenuItem> | ||
| </TextField> | ||
| <SelectTrigger id={lifetimeId} className="w-full"> |
There was a problem hiding this comment.
When this form replaces the MUI lifetime control with the Radix selector and conditionally reveals the custom expiration input, the existing CreateTokenPage story still only renders the default state and has no play function. Add a story interaction that opens the selector, chooses a preset and Custom, and verifies the expiration input appears so this user-visible control migration has the required behavioral coverage.
AGENTS.md reference: site/AGENTS.md:L9-L10
Useful? React with 👍 / 👎.
|
CI lint is saying: are you telling me this PR removes the last of emotion? |
That is exactly what I'm telling you 🥳 |
2 participants
Continue the MUI → Tailwind/shadcn migration across a few auth and settings surfaces.
TextField/MenuItem→FormField,Select, andInput(drops Emotion for section min-width)TextField→FormField/Textarea, matching the organization info formLink/TextField→ sharedLink,Input, andLabelStack→flex flex-row gap-2Also removes the now-unused
@emotion/cssdependency fromsite/package.json(and the lockfile), which was the last usage of it. This fixes theknipCI lint failure ("Unused dependencies: @emotion/css").