Skip to content

refactor(site): demui create template gallery and form - #27788

Merged
jakehwll merged 1 commit into
mainfrom
jakehwll/demui-createtemplate
Aug 4, 2026
Merged

refactor(site): demui create template gallery and form#27788
jakehwll merged 1 commit into
mainfrom
jakehwll/demui-createtemplate

Conversation

@jakehwll

@jakehwll jakehwll commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Migrate the create template gallery page and create template form off MUI and Emotion onto Tailwind and shared form/link primitives (FormField, Textarea, Link).

Migrate the create template gallery page and create template form off MUI and Emotion onto Tailwind and shared form/link primitives (`FormField`, `Textarea`, `Link`).

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 27b728b42b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +327 to 334
<FormField
field={getFieldHelpers("name")}
label="Name"
disabled={isSubmitting}
onChange={onChangeTrimmed(form)}
fullWidth
required
label="Name"
className="w-full"
/>

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add interaction coverage for the migrated form fields

This replaces the name control with a new form primitive, but CreateTemplateForm.stories.tsx is unchanged and none of its existing play functions type into or validate these fields. A regression in the new FormField event or error wiring therefore has no interaction coverage; add a story whose play function enters values and exercises validation or submission.

AGENTS.md reference: site/AGENTS.md:L9-L10

Useful? React with 👍 / 👎.

@jakehwll
jakehwll merged commit df17009 into main Aug 4, 2026
48 of 49 checks passed
@jakehwll
jakehwll deleted the jakehwll/demui-createtemplate branch August 4, 2026 16:11
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants