Skip to content

refactor(site): demui <ProvisionerTagsField /> - #27763

Merged
jakehwll merged 1 commit into
mainfrom
jakehwll/demui-provisioner-tags-field
Aug 3, 2026
Merged

refactor(site): demui <ProvisionerTagsField />#27763
jakehwll merged 1 commit into
mainfrom
jakehwll/demui-provisioner-tags-field

Conversation

@jakehwll

@jakehwll jakehwll commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Replace MUI TextField in ProvisionerTagsField with the shared Input component.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: def0a119aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

<TextField
inputRef={keyInputRef}
size="small"
<Input

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Let the replacement inputs shrink inside the tag row

In both callers, especially the 300px ProvisionerTagsPopover, this row is constrained by max-w-72, but each shared Input is a raw input with w-full and its automatic intrinsic minimum width. Unlike the previous MUI TextField wrapper, which supplies min-width: 0, the two inputs cannot shrink enough to coexist with the fixed-size add button and gaps, so the controls overflow the popover. Give both replacement inputs shrinkable sizing such as min-w-0.

Useful? React with 👍 / 👎.

@jakehwll
jakehwll merged commit 5e29a87 into main Aug 3, 2026
48 of 49 checks passed
@jakehwll
jakehwll deleted the jakehwll/demui-provisioner-tags-field branch August 3, 2026 09:09
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants