refactor(site): demui <ProvisionerTagsField /> - #27763
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: def0a119aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <TextField | ||
| inputRef={keyInputRef} | ||
| size="small" | ||
| <Input |
There was a problem hiding this comment.
Let the replacement inputs shrink inside the tag row
In both callers, especially the 300px ProvisionerTagsPopover, this row is constrained by max-w-72, but each shared Input is a raw input with w-full and its automatic intrinsic minimum width. Unlike the previous MUI TextField wrapper, which supplies min-width: 0, the two inputs cannot shrink enough to coexist with the fixed-size add button and gaps, so the controls overflow the popover. Give both replacement inputs shrinkable sizing such as min-w-0.
Useful? React with 👍 / 👎.
Replace MUI
TextFieldinProvisionerTagsFieldwith the sharedInputcomponent.