Skip to content

refactor(site): replace MUI update-check snackbar with <UpdateCheckNotice/> - #27728

Merged
jakehwll merged 4 commits into
mainfrom
jakehwll/updatechecknotice-demui
Aug 4, 2026
Merged

refactor(site): replace MUI update-check snackbar with <UpdateCheckNotice/>#27728
jakehwll merged 4 commits into
mainfrom
jakehwll/updatechecknotice-demui

Conversation

@jakehwll

@jakehwll jakehwll commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Replaces the MUI Snackbar / Link update-check toast in DashboardLayout with a Tailwind UpdateCheckNotice, and adds Storybook coverage for the layout and notice.

The notice stays declarative (not Sonner), offsets above the deployment banner when the user can view deployment stats, and otherwise sits at the normal bottom margin.

Old New
UPDATE_NOTICE_OLD UPDATE_NOTICE_NEW

…otice/>`

Replaces the MUI `Snackbar` / `Link` update-check toast in `DashboardLayout` with a Tailwind `UpdateCheckNotice`, and adds Storybook coverage for the layout and notice.

The notice stays declarative (not Sonner), offsets above the deployment banner when the user can view deployment stats, and otherwise sits at the normal bottom margin.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f0fac60b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread site/src/modules/dashboard/UpdateCheckNotice/UpdateCheckNotice.tsx Outdated
Comment thread site/src/modules/dashboard/DashboardLayout.stories.tsx Outdated
Comment thread site/src/modules/dashboard/DashboardLayout.stories.tsx
- Add accessible name to the dismiss button
- Export and reuse canonical query keys in DashboardLayout stories
- Derive the outdated update-check variant from MockUpdateCheck
Comment thread site/src/api/queries/buildInfo.ts Outdated
import { cachedQuery } from "./util";

const buildInfoKey = ["buildInfo"] as const;
export const buildInfoKey = ["buildInfo"] as const;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I'm noticing that the other key in this PR doesn't have as const. What is the codebase convention? We shouldn't have two different approaches

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair 🙂 Nuked

@jakehwll
jakehwll merged commit d23d0d5 into main Aug 4, 2026
26 checks passed
@jakehwll
jakehwll deleted the jakehwll/updatechecknotice-demui branch August 4, 2026 15:00
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants