refactor(site): redesign <AppearanceSettingsPage /> - #27722
Conversation
Documentation CheckUpdates Needed
Prose on that page still reads accurately, so no copy changes look required. One optional nit: the page says the application name is "displayed on the login page", while the new Branding helper text says the name and logo appear on the login page and in the dashboard. No action needed for the rest of the diff (component refactors, portal-based preview, draft-until-save dialog behavior, paywall copy, Automated review via Coder Agents |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9cb5dfd9d2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <HorizontalForm | ||
| onSubmit={form.handleSubmit} | ||
| aria-label="Appearance settings" | ||
| className="mt-8" |
There was a problem hiding this comment.
The inspected AppearanceSettingsPageView.stories.tsx and AnnouncementBannerDialog.stories.tsx only provide static arguments and have no play functions, while this commit introduces a combined branding submission flow and changes the banner creation, editing, toggling, and validation interactions. Add Storybook interactions that edit and submit the branding form and exercise the meaningful banner flows so these user-visible behavior changes receive the required coverage.
AGENTS.md reference: site/AGENTS.md:L9-L10
Useful? React with 👍 / 👎.
jeremyruppel
left a comment
jeremyruppel
left a comment
There was a problem hiding this comment.
code LGTM! redesign looks good to me as well but I'll leave that approval to our excellent design team
|
@jakehwll Are the screenshots showing an account with a premium license? I would expect the premium badge to disappear when the account is upgraded or the "Save" and text fields to be disabled if the account doesn't have a premium license. Those screenshots seem to show both states at the same time. |
These screenshots are completely with a premium license. The badge is still there in licensed situations in the old version.
|
Resolve conflicts from main in the appearance settings redesign: - IconField: take main`s merged demui version (#27719). - IconPickerField: accept main`s removal; call sites already use IconField. - AnnouncementBannerSettings: keep redesign, update ConfirmDialog import to the migrated Dialog path (#27506). - AnnouncementBannerDialog: port redesign onto the shadcn Dialog (#27506); render preview outside DialogContent; fix isCreating check. - AppearanceSettingsPageView: keep redesign layout, adopt main`s PaywallPremium badging and permissions prop (DEVEX-732 #27847).
3 participants
HorizontalForm/FormSection) for branding, with announcement banners as a secondarySettingsHeader+ table section (aligned with OAuth2 apps / AI Governance).IconFieldand reuse it for Logo URL (URL input, preview, emoji picker); thinIconPickerFieldto wrap the shared component.Switch/ menu icons, empty-state CTA) and clarify Premium paywall copy to cover branding and announcement banners.