refactor(site): migrate organization settings form off MUI - #27718
Conversation
jakehwll
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5192c5961
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| component: OrganizationSettingsPageView, | ||
| args: { | ||
| organization: MockOrganization, | ||
| onSubmit: action("onSubmit"), |
There was a problem hiding this comment.
When this commit replaces the organization info inputs, the stories register onSubmit but never use a play function to edit, validate, or submit the new controls, so regressions in trimming, validation, and submission will pass the Storybook suite. Add a story interaction that exercises these behaviors and asserts the submitted values.
AGENTS.md reference: site/AGENTS.md:L9-L10
Useful? React with 👍 / 👎.
aslilac
left a comment
aslilac
left a comment
There was a problem hiding this comment.
seems legit
I agree that horizontal forms need to go, and I think the delete button looks pretty bad with the new design, but you're not really making it worse, these are just things that are already bad. I clicked around in the ui and it seems functional.
Resolve conflict in OrganizationSettingsPageView.tsx and update DeleteDialog import path to Dialog/ after MUI dialog migration (#27506).
4 participants
Migrates the organization settings info form from MUI TextField to shared FormField/Input/Textarea patterns, and splits the page view into focused section components so info, workspace sharing, and delete are no longer one monolithic file.
Behavior is unchanged; this is structure and component migration only.