refactor(site): demui template settings forms - #27636
Merged
Merged
Conversation
…on setFieldValue The void operator was only needed on statement-body handlers to satisfy noFloatingPromises. On these expression-body arrows the promise is returned, not floating, so void was a no-op.
…dant void on formik calls noFloatingPromises is not enabled in the Biome config and merged code already calls form.setFieldValue as a floating statement, so void adds nothing. Removes it from the statement-body handlers too for consistency.
…tead of redeclaring valueMs/onChange/label/error/helperText have no native equivalent so they stay explicit, but disabled/className/id/name/placeholder/aria-*/ref are plain input attributes. Extend ComponentProps<typeof Input> and forward the rest to the inner Input, matching the old Omit<TextFieldProps> shape without the MUI dependency.
jakehwll
marked this pull request as ready for review
July 30, 2026 05:14
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71ab1666bd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- DurationField: track the previous prop instead of comparing against a toMs() round-trip, which truncates fractional units and could loop the render-phase setState forever on valid non-integer TTLs. - TemplateScheduleForm: forward each cleanup field's id, name, and onBlur to DurationField so Formik marks the field touched and surfaces positive-duration validation errors. - TemplateVariableField/Form: forward the Formik onBlur (and name) through instead of a no-op so required-variable errors show on blur.
jeremyruppel
reviewed
Aug 4, 2026
jeremyruppel
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the remaining MUI/Emotion usage from the Template Settings pages, moving them over to Tailwind and the shared component primitives.
What
<TemplateScheduleForm />— deMUI'd, along with the shared<DurationField />it relies on.<TemplateVariablesForm />/<TemplateVariableField />— deMUI'd.<TemplateSettingsForm />(general settings) — deMUI'd.No behavioural changes intended; this is a styling/plumbing refactor.