refactor(site/src/pages/AISettingsPage): replace IconPickerField with IconField - #27621
Closed
aqandrew wants to merge 3 commits into
Closed
refactor(site/src/pages/AISettingsPage): replace IconPickerField with IconField#27621aqandrew wants to merge 3 commits into
aqandrew wants to merge 3 commits into
Conversation
aqandrew
marked this pull request as ready for review
July 28, 2026 22:00
aqandrew
changed the title
aqandrew
changed the title
DanielleMaywood
requested changes
Jul 29, 2026
DanielleMaywood
left a comment
DanielleMaywood
left a comment
Contributor
There was a problem hiding this comment.
Actually.... the styling in that screenshot looks a little off
Contributor
We have two different colors |
Contributor
Author
|
closing in favor of #27719 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#26642 introduced a new component it probably shouldn't have,
IconPickerField, which is basically identical to our existingIconField. This PR removesIconPickerFieldand replaces it withIconField.The result is that we're now showing a MUI input in an otherwise shadcn form--but imo the slight style mismatch there is more acceptable than maintaining a duplicate component
see "Icon" field in the 3 o'clock region of the screenshot below: