fix: rollback appearance mutation cache updates - #25182
Merged
Merged
Conversation
Adds three new UserAppearanceSettings fields (theme_mode, theme_light, theme_dark) on top of the existing theme_preference and terminal_font. Replaces GetUserThemePreference and GetUserTerminalFont with a single GetUserAppearanceSettings aggregate query. The PUT handler is wrapped in db.InTx so sync-mode's mode + slot writes can never half-apply.
jaaydenh
force-pushed
the
pr25077/04-appearance-mutation-rollback
branch
from
May 14, 2026 13:41
9a691bb to
5674e9d
Compare
This reverts commit 5674e9d.
jaaydenh
changed the title
DanielleMaywood
approved these changes
May 15, 2026
DanielleMaywood
left a comment
DanielleMaywood
left a comment
Contributor
There was a problem hiding this comment.
I think the agent re-added some comments we removed earlier but other than that, lgtm.
DanielleMaywood
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependencies
Validation
pnpm -C site exec vitest run --project=unit src/api/queries/users.test.tspnpm -C site lint:types