feat(site): add theme mode frontend foundation - #25181
Merged
Merged
Conversation
…-foundation # Conflicts: # site/src/theme/darkTritan/roles.ts # site/src/theme/lightTritan/roles.ts
| onSelect, | ||
| }) => { | ||
| return ( | ||
| <div |
Contributor
There was a problem hiding this comment.
Why not fieldset?
Contributor
Author
There was a problem hiding this comment.
changed to fieldset
| size="lg" | ||
| label={THEME_COPY[displayedTheme].title} | ||
| /> | ||
| <div |
Contributor
Author
There was a problem hiding this comment.
changed to fieldset
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
DanielleMaywood
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usePreferredColorSchemeand refactorThemeProviderto use the shared theme mode resolver.Dependencies
Validation
pnpm -C site exec vitest run --project=unit src/theme/themeMode.test.ts src/theme/usePreferredColorScheme.test.tsxpnpm -C site lint:typespnpm -C site lint:knip