Skip to content

perf(site): memoize chat rendering hot path #23720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylecarbs merged 2 commits into from
Mar 27, 2026
Merged

perf(site): memoize chat rendering hot path #23720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ce85b8
perf(site): memoize chat rendering hot path
kylecarbs Mar 27, 2026
ac00657
chore: format with biome
kylecarbs Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions site/src/components/ai-elements/response.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,15 @@ const createComponents = (
};
};

// Precompute component maps for both themes at module scope so
// every Response instance shares the same stable references.
// This prevents Streamdown from discarding its cached render
// tree on each parent re-render.
const componentsByTheme: Record<FileViewerThemeType, Components> = {
light: createComponents("light", fileViewerTheme.light),
dark: createComponents("dark", fileViewerTheme.dark),
};

export const Response = ({
className,
children,
Expand All @@ -241,8 +250,7 @@ export const Response = ({
const theme = useTheme();
const fileViewerThemeType: FileViewerThemeType =
theme.palette.mode === "dark" ? "dark" : "light";
const viewerTheme = fileViewerTheme[fileViewerThemeType];
const components = createComponents(fileViewerThemeType, viewerTheme);
const components = componentsByTheme[fileViewerThemeType];

return (
<div
Expand Down
4 changes: 3 additions & 1 deletion site/src/pages/AgentsPage/components/AgentDetail/ConversationTimeline.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ const mockTextAttachmentFetch = () => {
const defaultArgs: Omit<
React.ComponentProps<typeof ConversationTimeline>,
"parsedMessages"
> = {};
> = {
subagentTitles: new Map(),
};

const meta: Meta<typeof ConversationTimeline> = {
title: "pages/AgentsPage/AgentDetail/ConversationTimeline",
Expand Down
Loading
Loading