fix(site): improve keyboard navigation in help popovers - #23374
Merged
aslilac merged 6 commits intoMar 31, 2026
Conversation
github-actions
Bot
added
the
community
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
cdrci2
added a commit
to coder/cla
that referenced
this pull request
Mar 20, 2026
Contributor
Author
|
recheck |
matifali
requested review from
a team and
jakehwll
and removed request for
a team
March 25, 2026 13:29
Contributor
|
Heads up: this PR uses Please pull a recent version of |
code-qtzl
force-pushed
the
fix/help-tooltip-keyboard-navigation
branch
from
March 28, 2026 00:59
cac08c2 to
7e49b47
Compare
jakehwll
reviewed
Mar 30, 2026
Contributor
There was a problem hiding this comment.
Could we rename this file to HelpPopover.tsx and update the component name and its consumers?
Contributor
|
Appears to have a conflict with 
|
code-qtzl
force-pushed
the
fix/help-tooltip-keyboard-navigation
branch
from
March 30, 2026 20:49
7e49b47 to
bb1b020
Compare
code-qtzl
changed the title
code-qtzl
changed the title
code-qtzl
changed the title
code-qtzl
changed the title
code-qtzl
changed the title
code-qtzl
changed the title
aslilac
reviewed
Mar 30, 2026
code-qtzl
force-pushed
the
fix/help-tooltip-keyboard-navigation
branch
from
March 31, 2026 15:03
f9629d7 to
4c18984
Compare
Co-authored-by: Kayla はな <[email protected]>
code-qtzl
force-pushed
the
fix/help-tooltip-keyboard-navigation
branch
from
March 31, 2026 15:19
25246a1 to
09dc9f3
Compare
aslilac
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes keyboard navigation in HelpTooltip components by replacing the underlying Tooltip primitive with Popover. Links inside help tooltips are now accessible via keyboard navigation.
Problem
When tabbing through the UI, users could focus on the help icon button and open the tooltip, but the links inside were not in the tab order. This made the links inaccessible to keyboard-only users, violating accessibility standards.
Solution
Replaced Radix UI's Tooltip primitive with Popover primitive in the HelpTooltip component. Popovers properly manage focus and keyboard navigation for interactive content, while Tooltips are designed only for non-interactive content.
Changes
Tooltipimports toPopoverinHelpTooltip.tsxHelpPopover.tsxtype="button"to trigger button for proper semanticsdisablePortalprop support for backward compatibilityBehavior Changes
Testing
Screenshot (gif)
Before
After