Conversation
nhooyr
force-pushed
the
expose-keybind
branch
2 times, most recently
from
f171819 to
1167833
Compare
nhooyr
changed the title
|
We need |
|
@code-asher yea my bad, exposed. |
| // tslint:disable no-any | ||
|
|
||
| import { ITerminalService } from "vs/workbench/contrib/terminal/common/terminal"; | ||
| import { IWorkbenchActionRegistry } from 'vs/workbench/common/actions'; |
There was a problem hiding this comment.
Importing from here won't work right?
It will within the project, but importing inside another would leave these unresolved.
There was a problem hiding this comment.
Not sure what you mean.
There was a problem hiding this comment.
Those files aren't included in the ide-api package so anything that imports it won't be able to resolve those types (only applies if you're using TypeScript of course). We'll want to fully encapsulate the API within the typings file before publishing a new version of the API.
There was a problem hiding this comment.
Why not just use the vscode typings? Why are we wrapping?
There was a problem hiding this comment.
We'd have to include VS Code's code with the ide-api package. Since the files we import may import other files, it'd probably be easiest to just import all of VS Code, but it feels odd (to me) to include the entirety of VS Code just for the types.
The way VS Code does it is to have an entirely separate typings file like we're doing here and redefine all the types. Actually maybe we can just import their typings file and re-export some things from it?
There was a problem hiding this comment.
There was a problem hiding this comment.
Actually that wouldn't work because that doesn't include types for their internal methods, just what they expose to extensions.
* upstream/master: Show hidden files by default Fix human readable byte size when zero Expose actions registry (coder#701) Set NODE_ENV and VERSION when building (coder#700) Don't try to create builtin extensions directory Suppress "disconnected" notification on extension host Extra extensions directories (coder#694) Updated Data Directory Flag (coder#664) Remove broken links (coder#671)
3 participants
No description provided.