Conversation
|
✨ code-server docs for PR #5308 is ready! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #5308 +/- ##
=======================================
Coverage 72.47% 72.47%
=======================================
Files 30 30
Lines 1671 1671
Branches 367 367
=======================================
Hits 1211 1211
Misses 397 397
Partials 63 63 Continue to review full report at Codecov.
|
I'm not sure what changed in the latest version but without setting VSCODE_DEV=1, code-server won't load. This fixes that.
This reverts commit 58c4826.
This reverts commit 902f5f2.
I am not sure why this is passing locally and failing CI. I need to further investigate this since it fails depending on where you test.
| const element = await codeServerPage.page.waitForSelector( | ||
| `div[role="dialog"] >> text=code-server: ${isDevMode ? "Unknown" : "v" + version}`, | ||
| ) | ||
| const element = await codeServerPage.page.waitForSelector(`div[role="dialog"] >> text=code-server`) |
There was a problem hiding this comment.
I spent half a day trying to debug this. The dialog shows the version as expected but running locally vs in CI results in different outcomes. I will fix this next sprint: #5312
| 1. Run `yarn release:github-draft` to create a GitHub draft release from the | ||
| template with the updated version. | ||
| template with the updated version. Make sure to update the `CHANGELOG.md`. | ||
| 1. Bump chart version in `Chart.yaml`. |
There was a problem hiding this comment.
Ah yes, that's intentional! That way if you re-order, you don't have to go renumber them.
There was a problem hiding this comment.
I was trying to find the specific place but I think it's this:
(b) if the list item is ordered, the start number must be 1.
Someone from Coder taught me it actually!
2 participants
This PR is to generate a new release of
code-serveratv4.5.0Screenshot
TODOs
Follow "Publishing a release" steps in
ci/README.mdFixes #5307
We had to do this a little differently. @Emyrk and I agreed we can merge this PR, delete the branch and then publish the release.