Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bloominstituteoftechnology/JavaScript-IV
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: codejoncode/JavaScript-IV
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 8 commits
  • 2 files changed
  • 1 contributor

Commits on Jun 28, 2018

  1. the refractoring is completed all prototypes convverted into classes

    @codejoncode
    codejoncode committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    11bf657 View commit details
    Browse the repository at this point in the history

  2. still plugging away creating the objects now to run test

    @codejoncode
    codejoncode committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    58bb889 View commit details
    Browse the repository at this point in the history

  3. i have two objects for each class created 

    likely going to attempt some stretch items

also will test out the code
    @codejoncode
    codejoncode committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    aac7f45 View commit details
    Browse the repository at this point in the history

  4. console.log every property discovered some that should have been inhe… 

    …rited were undefined

this was because i never defined them

fixed and everything works as should
    @codejoncode
    codejoncode committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    43cae3a View commit details
    Browse the repository at this point in the history

  5. testing the stretch problems out now starting with a grade that means… 

    … the student fails and I am going to try to increment it
    @codejoncode
    codejoncode committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    ceff998 View commit details
    Browse the repository at this point in the history

  6. so i have part of the stretch completed 

    it only goes through once so i am going to try to get it to continue until the student graduates
    @codejoncode
    codejoncode committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    7fc2a61 View commit details
    Browse the repository at this point in the history

  7. works as should goes until the student graduates 

     only one call needed

ran into an infinite loop this.grade instead of student.grade >= 70

luckily i used replit to debug

thinking on how i can avoid this in the future
    @codejoncode
    codejoncode committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    cb111d2 View commit details
    Browse the repository at this point in the history

  8. spelling error corrected

    @codejoncode
    codejoncode committed Jun 28, 2018
    Configuration menu
    Copy the full SHA
    5fb63c5 View commit details
    Browse the repository at this point in the history
Loading