Repository navigation
Travis fix - almost green - #127
Conversation
|
Any update on this? I'm looking forward to the green build! |
|
Hi, sorry i'll take a look tomorrow ! |
|
Any update on this? I'm already considering releasing my forked version to PYPI as a last resort... |
|
Hi, i can merge this the only failing tests are CLI, which is kind of beta stuff anyway. However i'm not going to have time to make a pypi release if that something you need. |
|
Awesome! I don't need a PYPI release in the nearest time horizon. I only need to see at least some progress. I can live with referencing this lib though git commit (as pip is able to do it :) ) This merge will also help few things:
Regarding the CLI interface part of this project, I should look at it, it sounds like something I might find useful :) Regarding the two failing tests, we can disable them and can create an issue for them, makes sense? |
|
Yes let's make them xfail, and we can check them out later. |
|
Who disable the tests? Me in my travis-fix branch, or you in master? Just asking to prevent the situation that we both do it and will have to resolve the conflicts... |
|
Could you do it in your fork and potentially even add this to this pr ? |
|
Hi. I disabled the two failing tests and all tests for 2.5, 2.6 and 2.7 finally pass! However flakes fail. I don't have much experience with flakes nor python static analyis at all. Any idea what's wrong there? |
|
not sure, did you try to run pyflakes locally ? |
|
I found that it has never worked. Nor locally, nor on your master branch. That's the reason why you have it in after_script. I tried to put it to tests, but there are problems which I'm not gonna solve in this PR (unused imports that are in fact used etc.) So I put it back to after_script :) We can create a separate issue for static code analysis... Gonna finally accept this PR? :) |
|
wow, nice ! |
Tries to fix #124
It all amost works, only two tests fail, because they don't find some repository or what. Any idea?