Skip to content

Travis fix - almost green - #127

Merged
marcinkuzminski merged 11 commits into
codeinn:masterfrom
stardust85:travis-fix
Feb 18, 2016
Merged

marcinkuzminski merged 11 commits into
codeinn:masterfrom
stardust85:travis-fix

Conversation

@stardust85

Copy link
Copy Markdown
Contributor

Tries to fix #124

It all amost works, only two tests fail, because they don't find some repository or what. Any idea?

@stardust85

Copy link
Copy Markdown
Contributor Author

Any update on this? I'm looking forward to the green build!

@marcinkuzminski

Copy link
Copy Markdown
Member

Hi, sorry i'll take a look tomorrow !

@stardust85

Copy link
Copy Markdown
Contributor Author

Any update on this? I'm already considering releasing my forked version to PYPI as a last resort...

@marcinkuzminski

Copy link
Copy Markdown
Member

Hi, i can merge this the only failing tests are CLI, which is kind of beta stuff anyway. However i'm not going to have time to make a pypi release if that something you need.

@stardust85

Copy link
Copy Markdown
Contributor Author

Awesome! I don't need a PYPI release in the nearest time horizon. I only need to see at least some progress. I can live with referencing this lib though git commit (as pip is able to do it :) ) This merge will also help few things:

  1. working CI is a good mark for both users and contributors
  2. I will not diverge too much from your master branch in my P4 branch
  3. people will see that this library isn't dead

Regarding the CLI interface part of this project, I should look at it, it sounds like something I might find useful :)

Regarding the two failing tests, we can disable them and can create an issue for them, makes sense?

@marcinkuzminski

Copy link
Copy Markdown
Member

Yes let's make them xfail, and we can check them out later.

@stardust85

Copy link
Copy Markdown
Contributor Author

Who disable the tests? Me in my travis-fix branch, or you in master? Just asking to prevent the situation that we both do it and will have to resolve the conflicts...

@marcinkuzminski

Copy link
Copy Markdown
Member

Could you do it in your fork and potentially even add this to this pr ?

@stardust85

Copy link
Copy Markdown
Contributor Author

Hi. I disabled the two failing tests and all tests for 2.5, 2.6 and 2.7 finally pass! However flakes fail. I don't have much experience with flakes nor python static analyis at all. Any idea what's wrong there?

@marcinkuzminski

Copy link
Copy Markdown
Member

not sure, did you try to run pyflakes locally ?

@stardust85

Copy link
Copy Markdown
Contributor Author

I found that it has never worked. Nor locally, nor on your master branch. That's the reason why you have it in after_script. I tried to put it to tests, but there are problems which I'm not gonna solve in this PR (unused imports that are in fact used etc.)

So I put it back to after_script :) We can create a separate issue for static code analysis...

Gonna finally accept this PR? :)

@marcinkuzminski

Copy link
Copy Markdown
Member

wow, nice !

marcinkuzminski added a commit that referenced this pull request Feb 18, 2016
@marcinkuzminski
marcinkuzminski merged commit e6cd941 into codeinn:master Feb 18, 2016
@stardust85
stardust85 deleted the travis-fix branch February 18, 2016 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

travis fails on mercurial version

2 participants