Skip to content
This repository was archived by the owner on May 18, 2024. It is now read-only.

Restore SUPPORTPATH, add PROJECTSUPPORTPATH - #2

Merged
MGatner merged 1 commit into
codeigniter4projects:developfrom
MGatner:reinstate-supportpath
Oct 7, 2019
Merged

MGatner merged 1 commit into
codeigniter4projects:developfrom
MGatner:reinstate-supportpath

Conversation

@MGatner

@MGatner MGatner commented Oct 7, 2019

Copy link
Copy Markdown
Collaborator

The framework actually uses SUPPORTPATH to do some the behind-the-scenes mocking (like the test logger) so defining our own without supplying the mock drivers breaks functions that rely on them (like log_message()). This PR restores SUPPORTPATH to its framework reference and adds a new constant, PROJECTSUPPORTPATH for developers to use in its place.

Existing tests that reference SUPPORTPATH explicitly should be updated.

@jim-parry

Copy link
Copy Markdown
Collaborator

Also makes sense to me.

@MGatner
MGatner merged commit 92af483 into codeigniter4projects:develop Oct 7, 2019
@MGatner
MGatner deleted the reinstate-supportpath branch October 7, 2019 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants