Skip to content

Curly braces as of PHP 7.4 are deprecated for accessing arrays. - #4

Closed
jbrahy wants to merge 4 commits into
codeigniter4:masterfrom
jbrahy:master
Closed

jbrahy wants to merge 4 commits into
codeigniter4:masterfrom
jbrahy:master

Conversation

@jbrahy

@jbrahy jbrahy commented Dec 22, 2019

Copy link
Copy Markdown

@jbrahy

jbrahy commented Dec 22, 2019

Copy link
Copy Markdown
Author

Adding PHP Comment stubs

@jbrahy

jbrahy commented Dec 22, 2019

Copy link
Copy Markdown
Author

Expanding abbreviations for easier readability.

@jim-parry

Copy link
Copy Markdown
Contributor

You are mixing several sets of changes into one PR ... bad practice, in case some are ok and some are not. Each PR should address a single issue or type of enhancement.
You also need to GPG-sign your commits.
PRs are NOT for the master branch - they should always be for the develop branch!
Related to this, you should always use feature branches to prepare PRs.
Too many things wrong with this one, sorry.

@jim-parry jim-parry closed this Dec 22, 2019
@jbrahy

jbrahy commented Dec 23, 2019

Copy link
Copy Markdown
Author

ok, I'll sort them out. Thanks

@jbrahy

jbrahy commented Dec 23, 2019

Copy link
Copy Markdown
Author

I only see the master branch.

@jim-parry

Copy link
Copy Markdown
Contributor

Ah - I see you are tryig to update the "framework" repo That is a read-only repo, bult from the "codeigniter4" repo.
It is build by the admin/release-framework script in the main repo, and files unique to it are found in "admin/framework".
Your intent is good, but you are going about it incorrectly :-/

karnadi added a commit to karnadi/framework that referenced this pull request Feb 26, 2020
i have an error like this
CRITICAL - 2020-02-26 15:28:28 --> Class 'Kint\Kint' not found
#0 /asni/apps/cms/0.1/system/CodeIgniter.php(224): require_once()
codeigniter4#1 /asni/apps/cms/0.1/system/CodeIgniter.php(193): CodeIgniter\CodeIgniter->initializeKint()
codeigniter4#2 /asni/apps/cms/0.1/system/bootstrap.php(168): CodeIgniter\CodeIgniter->initialize()
codeigniter4#3 /asni/www/codeigniter/4.0.0/index.php(38): require('/asni/apps/cms/...')
codeigniter4#4 /asni/www/index.php(17): require_once('/asni/www/codei...')
codeigniter4#5 {main}
karnadi added a commit to karnadi/framework that referenced this pull request Feb 26, 2020
fix this error 
CRITICAL - 2020-02-26 15:28:28 --> Class 'Kint\Kint' not found
#0 /asni/apps/cms/0.1/system/CodeIgniter.php(224): require_once()
codeigniter4#1 /asni/apps/cms/0.1/system/CodeIgniter.php(193): CodeIgniter\CodeIgniter->initializeKint()
codeigniter4#2 /asni/apps/cms/0.1/system/bootstrap.php(168): CodeIgniter\CodeIgniter->initialize()
codeigniter4#3 /asni/www/codeigniter/4.0.0/index.php(38): require('/asni/apps/cms/...')
codeigniter4#4 /asni/www/index.php(17): require_once('/asni/www/codei...')
codeigniter4#5 {main}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants