Skip to content

Add clearAll method (alias of clear) - #3

Closed
onepointking wants to merge 1 commit into
codeigniter4:masterfrom
onepointking:master
Closed

onepointking wants to merge 1 commit into
codeigniter4:masterfrom
onepointking:master

Conversation

@onepointking

Copy link
Copy Markdown

I think the default behavior of clear() should be to remove attachments, instead of leaving them in the message. I think it can lead to issues where unknowing developers send attachments to people they don't intend to.

I've also seen at least one post on Stack Overflow wondering why attachments are not being removed. Changing the default behavior at this point would be a breaking change which could lead to additional problems as people try to upgrade. I think adding this method is the least painful way to improve the behavior while not introducing a breaking change.

@onepointking

Copy link
Copy Markdown
Author

pull requested into the wrong repo. Apologies...

karnadi added a commit to karnadi/framework that referenced this pull request Feb 26, 2020
i have an error like this
CRITICAL - 2020-02-26 15:28:28 --> Class 'Kint\Kint' not found
#0 /asni/apps/cms/0.1/system/CodeIgniter.php(224): require_once()
codeigniter4#1 /asni/apps/cms/0.1/system/CodeIgniter.php(193): CodeIgniter\CodeIgniter->initializeKint()
codeigniter4#2 /asni/apps/cms/0.1/system/bootstrap.php(168): CodeIgniter\CodeIgniter->initialize()
codeigniter4#3 /asni/www/codeigniter/4.0.0/index.php(38): require('/asni/apps/cms/...')
codeigniter4#4 /asni/www/index.php(17): require_once('/asni/www/codei...')
codeigniter4#5 {main}
karnadi added a commit to karnadi/framework that referenced this pull request Feb 26, 2020
fix this error 
CRITICAL - 2020-02-26 15:28:28 --> Class 'Kint\Kint' not found
#0 /asni/apps/cms/0.1/system/CodeIgniter.php(224): require_once()
codeigniter4#1 /asni/apps/cms/0.1/system/CodeIgniter.php(193): CodeIgniter\CodeIgniter->initializeKint()
codeigniter4#2 /asni/apps/cms/0.1/system/bootstrap.php(168): CodeIgniter\CodeIgniter->initialize()
codeigniter4#3 /asni/www/codeigniter/4.0.0/index.php(38): require('/asni/apps/cms/...')
codeigniter4#4 /asni/www/index.php(17): require_once('/asni/www/codei...')
codeigniter4#5 {main}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant