Repository navigation
Add clearAll method (alias of clear) - #3
Closed
onepointking wants to merge 1 commit into
Closed
onepointking wants to merge 1 commit into
onepointking wants to merge 1 commit into
Conversation
Author
|
pull requested into the wrong repo. Apologies... |
karnadi
added a commit
to karnadi/framework
that referenced
this pull request
Feb 26, 2020
i have an error like this CRITICAL - 2020-02-26 15:28:28 --> Class 'Kint\Kint' not found #0 /asni/apps/cms/0.1/system/CodeIgniter.php(224): require_once() codeigniter4#1 /asni/apps/cms/0.1/system/CodeIgniter.php(193): CodeIgniter\CodeIgniter->initializeKint() codeigniter4#2 /asni/apps/cms/0.1/system/bootstrap.php(168): CodeIgniter\CodeIgniter->initialize() codeigniter4#3 /asni/www/codeigniter/4.0.0/index.php(38): require('/asni/apps/cms/...') codeigniter4#4 /asni/www/index.php(17): require_once('/asni/www/codei...') codeigniter4#5 {main}
karnadi
added a commit
to karnadi/framework
that referenced
this pull request
Feb 26, 2020
fix this error CRITICAL - 2020-02-26 15:28:28 --> Class 'Kint\Kint' not found #0 /asni/apps/cms/0.1/system/CodeIgniter.php(224): require_once() codeigniter4#1 /asni/apps/cms/0.1/system/CodeIgniter.php(193): CodeIgniter\CodeIgniter->initializeKint() codeigniter4#2 /asni/apps/cms/0.1/system/bootstrap.php(168): CodeIgniter\CodeIgniter->initialize() codeigniter4#3 /asni/www/codeigniter/4.0.0/index.php(38): require('/asni/apps/cms/...') codeigniter4#4 /asni/www/index.php(17): require_once('/asni/www/codei...') codeigniter4#5 {main}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the default behavior of clear() should be to remove attachments, instead of leaving them in the message. I think it can lead to issues where unknowing developers send attachments to people they don't intend to.
I've also seen at least one post on Stack Overflow wondering why attachments are not being removed. Changing the default behavior at this point would be a breaking change which could lead to additional problems as people try to upgrade. I think adding this method is the least painful way to improve the behavior while not introducing a breaking change.