Skip to content

Commit a8fb899

Browse files
committed
Implement TaskServiceTest.java
* add JUnit 4 dependency * remove autowired members from constructors
1 parent 327b0e4 commit a8fb899

4 files changed

Lines changed: 46 additions & 15 deletions

File tree

‎pom.xml‎

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@
2525
<groupId>org.springframework.boot</groupId>
2626
<artifactId>spring-boot-starter-web</artifactId>
2727
</dependency>
28-
29-
<dependency>
30-
<groupId>com.h2database</groupId>
31-
<artifactId>h2</artifactId>
32-
<scope>runtime</scope>
33-
</dependency>
3428
<dependency>
3529
<groupId>org.springframework.boot</groupId>
3630
<artifactId>spring-boot-starter-test</artifactId>
@@ -42,9 +36,13 @@
4236
<version>8.0.19</version>
4337
<scope>runtime</scope>
4438
</dependency>
39+
<dependency>
40+
<groupId>junit</groupId>
41+
<artifactId>junit</artifactId>
42+
<scope>test</scope>
43+
</dependency>
4544
</dependencies>
4645

47-
4846
<build>
4947
<plugins>
5048
<plugin>

‎src/main/java/com/codeherk/taskapi/controller/TaskController.java‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,10 @@
1717
public class TaskController {
1818

1919
@Autowired
20-
private final TaskService taskService;
20+
private TaskService taskService;
2121

22-
TaskController(TaskService taskService) {
23-
this.taskService = taskService;
24-
}
22+
// Constructors are inferred
23+
// TaskController(){}
2524

2625

2726
// Aggregate root

‎src/main/java/com/codeherk/taskapi/service/TaskService.java‎

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,9 @@
1111
@Service
1212
public class TaskService {
1313
@Autowired
14-
private final TaskRepository repository;
14+
private TaskRepository repository;
1515

16-
public TaskService(TaskRepository repository) {
17-
this.repository = repository;
18-
}
16+
// public TaskService() {}
1917

2018
public List<Task> getTasks() {
2119
return repository.findAll();
Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
package com.codeherk.taskapi.service;
2+
3+
import com.codeherk.taskapi.model.Task;
4+
import com.codeherk.taskapi.repo.TaskRepository;
5+
import org.junit.Test;
6+
import org.junit.runner.RunWith;
7+
import org.mockito.InjectMocks;
8+
import org.mockito.Mock;
9+
import org.mockito.Mockito;
10+
import org.mockito.junit.MockitoJUnitRunner;
11+
12+
import java.util.Optional;
13+
14+
import static org.assertj.core.api.Assertions.assertThat;
15+
16+
@RunWith(MockitoJUnitRunner.class)
17+
public class TaskServiceTest {
18+
19+
@Mock
20+
private TaskRepository taskRepository;
21+
22+
@InjectMocks
23+
private TaskService taskService;
24+
25+
@Test
26+
public void whenValidName_thenEmployeeShouldBeFound() {
27+
Task t = new Task("Hello world!");
28+
Mockito.when(taskRepository.findById(0L)).thenReturn(Optional.of(t));
29+
30+
Long taskId = 0L;
31+
Task found = taskService.getTaskById(taskId);
32+
33+
assertThat(found.getDescription())
34+
.isEqualTo(found.getDescription());
35+
}
36+
}

0 commit comments

Comments
 (0)