Skip to content

Fix CWE-89 (SQL Injection) — automated red/blue remediation #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codegm2020 wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix CWE-89 (SQL Injection) — automated red/blue remediation #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
285c35d
fix(CWE-89): BenchmarkTest00018 — SQL Injection (red-verified, round 1)
Sep 28, 2026
088e68b
fix(CWE-89): BenchmarkTest00025 — SQL Injection (red-verified, round 2)
Sep 28, 2026
654605c
fix(CWE-89): BenchmarkTest00026 — SQL Injection (red-verified, round 1)
Sep 28, 2026
e8b7da4
fix(CWE-89): BenchmarkTest00027 — SQL Injection (red-verified, round 1)
Sep 28, 2026
0e13fac
fix(CWE-89): BenchmarkTest00033 — SQL Injection (red-verified, round 2)
Sep 28, 2026
0c4452c
fix(CWE-89): BenchmarkTest00037 — SQL Injection (red-verified, round 1)
Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00018.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,15 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
// URL Decode the header value since req.getHeaders() doesn't. Unlike req.getParameters().
param = java.net.URLDecoder.decode(param, "UTF-8");

String sql = "INSERT INTO users (username, password) VALUES ('foo','" + param + "')";
String sql = "INSERT INTO users (username, password) VALUES (?, ?)";

try {
java.sql.Statement statement =
org.owasp.benchmark.helpers.DatabaseHelper.getSqlStatement();
int count = statement.executeUpdate(sql);
java.sql.Connection connection =
org.owasp.benchmark.helpers.DatabaseHelper.getSqlStatement().getConnection();
java.sql.PreparedStatement statement = connection.prepareStatement(sql);
statement.setString(1, "foo");
statement.setString(2, param);
int count = statement.executeUpdate();
org.owasp.benchmark.helpers.DatabaseHelper.outputUpdateComplete(sql, response);
} catch (java.sql.SQLException e) {
if (org.owasp.benchmark.helpers.DatabaseHelper.hideSQLErrors) {
Expand Down
32 changes: 18 additions & 14 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00025.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,24 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
String param = request.getParameter("BenchmarkTest00025");
if (param == null) param = "";

String sql = "SELECT userid from USERS where USERNAME='foo' and PASSWORD='" + param + "'";
try {
// Long results =
// org.owasp.benchmark.helpers.DatabaseHelper.JDBCtemplate.queryForLong(sql);
Long results =
org.owasp.benchmark.helpers.DatabaseHelper.JDBCtemplate.queryForObject(
sql, Long.class);
response.getWriter().println("Your results are: " + String.valueOf(results));
} catch (org.springframework.dao.EmptyResultDataAccessException e) {
response.getWriter()
.println(
"No results returned for query: "
+ org.owasp.esapi.ESAPI.encoder().encodeForHTML(sql));
} catch (org.springframework.dao.DataAccessException e) {
String sql = "SELECT userid from USERS where USERNAME=? and PASSWORD=?";
try (java.sql.Connection connection =
org.owasp.benchmark.helpers.DatabaseHelper.getSqlConnection();
java.sql.PreparedStatement statement = connection.prepareStatement(sql)) {
statement.setString(1, "foo");
statement.setString(2, param);
try (java.sql.ResultSet resultSet = statement.executeQuery()) {
if (resultSet.next()) {
Long results = resultSet.getLong(1);
response.getWriter().println("Your results are: " + String.valueOf(results));
} else {
response.getWriter()
.println(
"No results returned for query: "
+ org.owasp.esapi.ESAPI.encoder().encodeForHTML(sql));
}
}
} catch (java.sql.SQLException e) {
if (org.owasp.benchmark.helpers.DatabaseHelper.hideSQLErrors) {
response.getWriter().println("Error processing request.");
} else throw new ServletException(e);
Expand Down
12 changes: 8 additions & 4 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00026.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,14 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
String param = request.getParameter("BenchmarkTest00026");
if (param == null) param = "";

String sql = "SELECT * from USERS where USERNAME='foo' and PASSWORD='" + param + "'";
String sql = "SELECT * from USERS where USERNAME=? and PASSWORD=?";
try {
org.springframework.jdbc.support.rowset.SqlRowSet results =
org.owasp.benchmark.helpers.DatabaseHelper.JDBCtemplate.queryForRowSet(sql);
java.sql.Connection connection =
org.owasp.benchmark.helpers.DatabaseHelper.getSqlConnection();
java.sql.PreparedStatement statement = connection.prepareStatement(sql);
statement.setString(1, "foo");
statement.setString(2, param);
java.sql.ResultSet results = statement.executeQuery();
response.getWriter().println("Your results are: ");

while (results.next()) {
Expand All @@ -65,7 +69,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
.println(
"No results returned for query: "
+ org.owasp.esapi.ESAPI.encoder().encodeForHTML(sql));
} catch (org.springframework.dao.DataAccessException e) {
} catch (java.sql.SQLException e) {
if (org.owasp.benchmark.helpers.DatabaseHelper.hideSQLErrors) {
response.getWriter().println("Error processing request.");
} else throw new ServletException(e);
Expand Down
11 changes: 7 additions & 4 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00027.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,15 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
String param = request.getParameter("BenchmarkTest00027");
if (param == null) param = "";

String sql = "INSERT INTO users (username, password) VALUES ('foo','" + param + "')";
String sql = "INSERT INTO users (username, password) VALUES (?, ?)";

try {
java.sql.Statement statement =
org.owasp.benchmark.helpers.DatabaseHelper.getSqlStatement();
int count = statement.executeUpdate(sql);
java.sql.Connection connection =
org.owasp.benchmark.helpers.DatabaseHelper.getSqlStatement().getConnection();
java.sql.PreparedStatement statement = connection.prepareStatement(sql);
statement.setString(1, "foo");
statement.setString(2, param);
int count = statement.executeUpdate();
org.owasp.benchmark.helpers.DatabaseHelper.outputUpdateComplete(sql, response);
} catch (java.sql.SQLException e) {
if (org.owasp.benchmark.helpers.DatabaseHelper.hideSQLErrors) {
Expand Down
40 changes: 21 additions & 19 deletions src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00033.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,28 +48,30 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
if (values != null) param = values[0];
}

String sql = "SELECT * from USERS where USERNAME='foo' and PASSWORD='" + param + "'";
String sql = "SELECT * from USERS where USERNAME=? and PASSWORD=?";
try {
org.springframework.jdbc.support.rowset.SqlRowSet results =
org.owasp.benchmark.helpers.DatabaseHelper.JDBCtemplate.queryForRowSet(sql);
response.getWriter().println("Your results are: ");
javax.sql.DataSource dataSource =
org.owasp.benchmark.helpers.DatabaseHelper.getSqlDataSource();
try (java.sql.Connection connection = dataSource.getConnection();
java.sql.PreparedStatement statement = connection.prepareStatement(sql)) {
statement.setString(1, "foo");
statement.setString(2, param);
try (java.sql.ResultSet results = statement.executeQuery()) {
response.getWriter().println("Your results are: ");

while (results.next()) {
response.getWriter()
.println(
org.owasp
.esapi
.ESAPI
.encoder()
.encodeForHTML(results.getString("USERNAME"))
+ " ");
while (results.next()) {
response.getWriter()
.println(
org.owasp
.esapi
.ESAPI
.encoder()
.encodeForHTML(results.getString("USERNAME"))
+ " ");
}
}
}
} catch (org.springframework.dao.EmptyResultDataAccessException e) {
response.getWriter()
.println(
"No results returned for query: "
+ org.owasp.esapi.ESAPI.encoder().encodeForHTML(sql));
} catch (org.springframework.dao.DataAccessException e) {
} catch (java.sql.SQLException e) {
if (org.owasp.benchmark.helpers.DatabaseHelper.hideSQLErrors) {
response.getWriter().println("Error processing request.");
} else throw new ServletException(e);
Expand Down
3 changes: 2 additions & 1 deletion src/main/java/org/owasp/benchmark/testcode/BenchmarkTest00037.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
}
}

String sql = "SELECT * from USERS where USERNAME=? and PASSWORD='" + param + "'";
String sql = "SELECT * from USERS where USERNAME=? and PASSWORD=?";

try {
java.sql.Connection connection =
Expand All @@ -70,6 +70,7 @@ public void doPost(HttpServletRequest request, HttpServletResponse response)
java.sql.ResultSet.CONCUR_READ_ONLY,
java.sql.ResultSet.CLOSE_CURSORS_AT_COMMIT);
statement.setString(1, "foo");
statement.setString(2, param);
statement.execute();
org.owasp.benchmark.helpers.DatabaseHelper.printResults(statement, sql, response);
} catch (java.sql.SQLException e) {
Expand Down