Skip to content

Add custom footer with author and last modification metadata#9

Open
dotcomaki wants to merge 6 commits intocodeday:mainfrom
dotcomaki:main
Open

Add custom footer with author and last modification metadata#9
dotcomaki wants to merge 6 commits intocodeday:mainfrom
dotcomaki:main

Conversation

@dotcomaki
Copy link
Copy Markdown
Contributor

Fixes #4

  • Adds a custom footer
  • Author and Last Modified by metadata is fetched from Github Actions

@dotcomaki dotcomaki requested review from a team, Nexite and oohwooh and removed request for Nexite April 16, 2026 11:26
@dotcomaki dotcomaki added the enhancement New feature or request label Apr 16, 2026
oohwooh
oohwooh previously approved these changes Apr 18, 2026
Copy link
Copy Markdown
Member

@oohwooh oohwooh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is great, thank you for the work on this!

This could be merged today, a couple thoughts I have though, that would imo make this change better. It's up to you if you want to implement them or not:

  • I think adding profile pictures would be nice, like we have in the similar footers on a lot of other CodeDay sites.

  • Some way to cache the data might be helpful. I don't know the best way to implement this but as the number of files grow, it makes it more and more likely we'll hit API limits (and even without api limits, it's still a bunch of unnecessary requests)

  • I think the last modified date should be under the page header, in the footer it's easy to miss and sometimes it can be really relevant. It would be really frustrating to spend x amount of time reading a page, get to the bottom and find out it's 5 years old and probably no longer relevant.

  • Knowing who specifically made the last contribution I don't think is very helpful information. We could sort the list of authors by their last contribution to still have this information present, without needing to state it twice.

Comment thread .github/scripts/inject_metadata.py Outdated
Comment thread .gitignore Outdated
@oohwooh
Copy link
Copy Markdown
Member

oohwooh commented Apr 18, 2026

I also think @iPrakharV should make a commit to this PR so he can get credit for his work on it too :)

@dotcomaki dotcomaki requested a review from oohwooh April 20, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance + Display Metadata

3 participants