bpo-39184: Fix incorrect return value (pythonGH-18580)

miss-islington · zooba · web-flow · commit d0a464e31ac6 · 2020-02-20T14:44:47.000-08:00
https://bugs.python.org/issue39184 Automerge-Triggered-By: @zooba (cherry picked from commit 6c444d0) Co-authored-by: Steve Dower <steve.dower@python.org>
diff --git a/PC/msvcrtmodule.c b/PC/msvcrtmodule.c
@@ -180,7 +180,7 @@ msvcrt_open_osfhandle_impl(PyObject *module, void *handle, int flags)
     int fd;
 
     if (PySys_Audit("msvcrt.open_osfhandle", "Ki", handle, flags) < 0) {
-        return NULL;
+        return -1;
     }
 
     _Py_BEGIN_SUPPRESS_IPH

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ msvcrt_open_osfhandle_impl(PyObject module, void handle, int flags)`
`180`	`180`	`int fd;`
`181`	`181`
`182`	`182`	`if (PySys_Audit("msvcrt.open_osfhandle", "Ki", handle, flags) < 0) {`
`183`		`- return NULL;`
	`183`	`+ return -1;`
`184`	`184`	`}`
`185`	`185`
`186`	`186`	`_Py_BEGIN_SUPPRESS_IPH`