Skip to content

Commit f44a98a

Browse files
authored
Update Test_Procedures.py
1 parent 93c1ee8 commit f44a98a

1 file changed

Lines changed: 15 additions & 15 deletions

File tree

samples/Test_Procedures.py

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -19,27 +19,27 @@ class Test_1_Procedures:
1919
# This method assumes JE's are already sorted in ascending order
2020

2121
@output_decorator
22-
def check_for_gaps_in_JE_ID(GL_Detail_YYYYMMDD_YYYYMMDD, Journal_ID_Column = 'Journal_ID'):
23-
22+
def check_for_gaps_in_JE_ID(GL_Detail,
23+
Journal_ID_Column = 'Journal_ID',
24+
output_file = 'Output_Folder/Test_3_1_1_check_for_gaps_in_JE_ID.csv'):
2425
gaps = []
2526
previous = None
26-
writer = csv.writer(open("Output_Folder/Test_3_1_1_check_for_gaps_in_JE_ID.csv", 'w'))
2727

28-
for item in GL_Detail_YYYYMMDD_YYYYMMDD[Journal_ID_Column]:
29-
if not previous:
30-
previous = item
31-
continue
32-
33-
if item - previous > 1:
34-
writer.writerow([f'Gap identified! {previous} is followed by {item}'])
28+
# Loop through each Journal ID, compare to previous
29+
for item in GL_Detail[Journal_ID_Column]:
30+
if previous and (item - previous > 1):
3531
gaps.append([previous, item])
36-
3732
previous = item
38-
39-
writer.writerow(['Test Results:'])
40-
writer.writerow([f'Total of {len(gaps)} gaps found'])
4133

42-
return ({"results":len(gaps), "output":"Output_Folder/Test_3_1_1_check_for_gaps_in_JE_ID.csv"})
34+
# Write results to the output csv file.
35+
with open(output_file, 'w') as file:
36+
writer = csv.writer(file)
37+
writer.writerow([f'Gap identified! Start gap number is followed by end gap number'])
38+
writer.writerows(gaps)
39+
writer.writerow(['Test Results:'])
40+
writer.writerow([f'Total of {len(gaps)} gaps found'])
41+
42+
return ({"results":len(gaps), "output":output_file})
4343

4444

4545
# 3.1.2 Compare listing of journal entry numbers from system to log file

0 commit comments

Comments
 (0)