Repository navigation
Step1 ~step3 로그인 구현까지 pr합니다. - #155
Merged
Merged
Conversation
javajigi
approved these changes
Feb 22, 2019
| } | ||
|
|
||
| @PostMapping("/loginUser") | ||
| public String login(UserDto userDto, HttpSession session) throws UnAuthenticationException { |
Contributor
There was a problem hiding this comment.
String userId, String password로 인자를 받아도 됨
|
|
||
| import codesquad.domain.Issue; | ||
|
|
||
| public class IssueDto { |
Contributor
There was a problem hiding this comment.
Issue와 IssueDto 사이에 큰 차이점이 없으면 Issue만 있어도 되지 않을까?
| return "redirect:/issues/list"; | ||
| } | ||
|
|
||
| @GetMapping("/list") |
| } | ||
|
|
||
| @PutMapping("/{id}") | ||
| @PutMapping("/{id}/update") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DTO 적용하여 로그인 구현하였습니다.
피드백 부탁드리겠습니다.
이슈 추가, 수정, 삭제는 피드백과 더불어 진행하겠습니다.