Skip to content

Step6 - #153

Merged
javajigi merged 1 commit into
code-squad:SeEunKimfrom
SeEunKim:step6
Jan 29, 2019
Merged

Step6#153
javajigi merged 1 commit into
code-squad:SeEunKimfrom
SeEunKim:step6

Conversation

@SeEunKim

Copy link
Copy Markdown

No description provided.

@javajigi
javajigi changed the base branch from master to SeEunKim January 29, 2019 07:18

@javajigi javajigi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현 잘 했네요. 💯
피드백 하나 남겼으니 다음 단계에서 적용해 보세요.


public void setSize(long size) {
this.size = size;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생성자 활용해 객체를 생성하기 때문에 굳이 setter 메소드가 필요없지 않을까?

@javajigi
javajigi merged commit d47c34c into code-squad:SeEunKim Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants