Skip to content

Step4 - #134

Merged
javajigi merged 6 commits into
code-squad:gbeea1004from
gbeea1004:step4
Jan 13, 2019
Merged

Step4#134
javajigi merged 6 commits into
code-squad:gbeea1004from
gbeea1004:step4

Conversation

@gbeea1004

Copy link
Copy Markdown

No description provided.

@javajigi javajigi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트가 없어 약간의 아쉬움이 있지만 전체적으로 구현 잘 했네요. 💯
구현에 집중한 것 잘 했어요. 작은 피드백 하나 남겼어요.


@Controller
@RequestMapping("/milestones")
public class milestoneController {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

클래스 이름은 대문자로 시작

alert("적용 되었습니다!");
}
})
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4단계에 벌써 ajax 적용 👍

@javajigi
javajigi merged commit 49cf466 into code-squad:gbeea1004 Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants