Skip to content

Step4 - #131

Merged
javajigi merged 3 commits into
code-squad:daesoopfrom
daesoop:step4
Jan 9, 2019
Merged

Step4#131
javajigi merged 3 commits into
code-squad:daesoopfrom
daesoop:step4

Conversation

@daesoop

@daesoop daesoop commented Jan 9, 2019

Copy link
Copy Markdown

No description provided.

@javajigi javajigi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현 잘 했네요. 👍
피드백 하나 남겼으니 다음 단계에 적용해 보세요.

this.subject = subject;
this.comment = content;
this.writer = writer;
this.deleted = deleted;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

생성자를 인스턴스 변수의 수 만큼 생성하고 있는데 좋은 방법은 아님
반드시 필요한 생성자만 추가할 것을 추천

@javajigi
javajigi merged commit 5412af6 into code-squad:daesoop Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants