Repository navigation
Step3 - #120
Merged
Merged
Step3#120
Conversation
Contributor
|
@gbeea1004 |
javajigi
suggested changes
Jan 6, 2019
| this.writer = writer; | ||
| } | ||
|
|
||
| public Issue(long id, String subject, String comment, User writer) { |
Contributor
There was a problem hiding this comment.
생성자가 너무 많은데 좀 줄일 수 있는 방법은 없을까?
| } | ||
|
|
||
| this.contents.setSubject(updateIssueContents.getSubject()); | ||
| this.contents.setComment(updateIssueContents.getComment()); |
Contributor
There was a problem hiding this comment.
contents.update(updateIssueContents) 또는 this.contents = updateIssueContents 는 어떨까?
|
|
||
| public interface IssueRepository extends JpaRepository<Issue, Long> { | ||
| Iterable<Issue> findByDeleted(boolean deleted); | ||
| Optional<Issue> findBySubject(String subject); |
Contributor
There was a problem hiding this comment.
이 메소드가 왜 필요한가? 이 메소드 없이 구현할 수 없을까?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
질문~~
이슈 삭제를 jquery를 통해 에러가 발생하면 alert 창을 띄우도록 구현을 했는데
브라우저에서 이슈 삭제 시 정상적으로 이슈가 삭제는 되는데 ajax 상에서 error메서드를 호출하네요..
이유를 모르겠습니다..
IssueAcceptanceTest 에서 테스트 케이스 작성 후 테스트를 하려는데
에러가 계속 뜨는데 이유를 모르겠어요ㅠㅠ