Skip to content

Step2 PR - #101

Merged
javajigi merged 2 commits into
code-squad:zingoworksfrom
vamboo26:step2
Dec 27, 2018
Merged

javajigi merged 2 commits into
code-squad:zingoworksfrom
vamboo26:step2

Conversation

@vamboo26

Copy link
Copy Markdown

안녕하세요, 포비!
Step2 PR 및 질문 드립니다.

  • issue의 기본 uri를 기존처럼 issues로 정했다가 뼈대에 newIssue가 있어서 변경했는데, 특별한 이유가 있는건가요? 저는 통일성을 위해 issues로 구현하고자 하는데 다른 이유가 있나 해서 여쭤봅니다.

@javajigi

Copy link
Copy Markdown
Contributor

@zingoworks
다음 이유는 없음.
본인이 구현하고 싶은데로 변경해도 괜찮음.

@javajigi javajigi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현 잘 했네. 👍
피드백 몇 개 남겼으니 다음 단계 적용해 보세요.

super(id);
this.subject = subject;
this.comment = comment;
this.writer = writer;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 생성자가 너무 많음.
꼭 필요한 생성자가 가지도록 구현



@Controller
@RequestMapping("/newIssue")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"issues"로 구현할 것을 추천

@javajigi
javajigi merged commit 4cefb73 into code-squad:zingoworks Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants