Skip to content

submit step3 1st - #88

Merged
javajigi merged 2 commits into
code-squad:kkssryfrom
kkssry:step3
Oct 11, 2018
Merged

javajigi merged 2 commits into
code-squad:kkssryfrom
kkssry:step3

Conversation

@kkssry

@kkssry kkssry commented Oct 10, 2018

Copy link
Copy Markdown

No description provided.

@javajigi javajigi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 몇 개 남겼는데요. 다음 단계 구현할 때 적용해 보세요.

list1.add(1.0);
list1.add(2.0);
list1.add(3.0);
list1.add(4.0);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arrays.asList()를 사용하면 좀 더 깔끔하게 구현할 수 있음.

String dot = "●";
for (Point point : points) {
if(point.isY(y) && point.isX(x)) {
if (point.isY(y) && point.isX(x)) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

point.matchPoint(x, y);로 구현하는 것은 어떨까?

return lengthArr;
}

public int CalculatorSquare() {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메소드 이름 소문자???

@javajigi
javajigi merged commit f470730 into code-squad:kkssry Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants