Skip to content

Step2 PR 요청합니다. - #79

Merged
javajigi merged 3 commits into
code-squad:kkssryfrom
kkssry:step2
Oct 10, 2018
Merged

javajigi merged 3 commits into
code-squad:kkssryfrom
kkssry:step2

Conversation

@kkssry

@kkssry kkssry commented Oct 8, 2018

Copy link
Copy Markdown

말씀 하신 대로 이중 for문으로 골칫거리인 점 찍는 것을 해결했습니다.

@javajigi
javajigi changed the base branch from master to kkssry October 9, 2018 02:44

@javajigi javajigi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현 잘 했네요. 👍
단, skull의 경우 코딩 컨벤션을 지키는 않는 경우들이 계속 보이는데요. 좀 더 신경쓰면 좋을 것 같아요.

Comment thread src/main/java/coordinate/Point.java Outdated
this.y = y;
}

public double CalculatorLength(Point points) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메소드 이름은 소문자

Comment thread src/main/java/coordinate/Point.java Outdated
this.y = y;
}

public double CalculatorLength(Point points) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변수 이름은 points인 복수가 아니라 단수형으로

Comment thread src/main/java/coordinate/Point.java Outdated
public Boolean isX(int x) {
if (this.x * 3 == x)
return true;
return false;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return this.x * 3 == x로 구현 가능

Comment thread src/main/java/coordinate/Point.java Outdated
public Boolean isY(int y) {
if (this.y == y)
return true;
return false;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return this.y == y;로 구현 가능

Comment thread src/main/java/coordinate/InputView.java Outdated
import java.util.*;

public class InputView {
private static StringTokenizer STZ;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 변수 이름은 왜 대문자인가?

System.out.println();
}
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

테스트 코드 구현 👍

@javajigi
javajigi merged commit 573d0ac into code-squad:kkssry Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants