Repository navigation
Step2 push - #75
Merged
Merged
Step2 push#75
Conversation
javajigi
suggested changes
Oct 9, 2018
|
|
||
| public class Calculator { | ||
|
|
||
| public static double line(ArrayList<Point> points) { |
Contributor
There was a problem hiding this comment.
이 메소드 로직을 Point가 구현하도록 개선해 보고 현재 코드와 비교해 본다.
어느 구현이 더 나은가?
|
|
||
| public void disPlay(ArrayList<Point> points) { | ||
| for (Point point : points) { | ||
| field.get(point.getYPoint()).getCoordinateLine().get(point.getXPoint()).toStar(); |
Contributor
There was a problem hiding this comment.
상태를 가지는 객체의 데이터를 꺼내려(get)하지 말고 객체에 메시지를 보내라는 원칙에 따라 구현한다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.