Skip to content

submit coordinate step1 1st - #66

Merged
javajigi merged 1 commit into
code-squad:kkssryfrom
kkssry:step1
Oct 4, 2018
Merged

javajigi merged 1 commit into
code-squad:kkssryfrom
kkssry:step1

Conversation

@kkssry

@kkssry kkssry commented Oct 4, 2018

Copy link
Copy Markdown

세로와 가로의 길이를 맞추는 것 때문에 고민이 많았습니다.
2단계부터 점을 찍어야 하는데 X좌표 숫자와 동일한 위치에서 찍기 위해서 고민을 했습니다.

@javajigi javajigi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드 구현은 잘 했는데 code convetion을 어기는 경우가 있네요.
앞으로 주의해서 구현하면 좋을 것 같아요.

public static void main(String[] args) {
PrintView.drawVertical();
PrintView.drawRow();
PrintView.rowNumber();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

들여쓰기 convention에 맞지 않음.


import static org.assertj.core.api.Assertions.assertThat;

public class ladderTest {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

클래스 이름은 대문자로 시작

@javajigi
javajigi merged commit cab7403 into code-squad:kkssry Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants