Repository navigation
Step2 pr합니다. - #128
Merged
Merged
Step2 pr합니다.#128
Conversation
javajigi
suggested changes
Nov 2, 2018
|
|
||
| private static void locationCriteria(int line, int pointX, int pointY, int coordinatesX) { | ||
| if (condition(pointX, coordinatesX) && condition(pointY, line)) { | ||
| input = POINT; |
Contributor
There was a problem hiding this comment.
input을 전역 변수로 두고 구현하기 보다 로컬 변수로 구현해본다.
| public class Movement { | ||
|
|
||
| private static final int MAX_NUM = 24; | ||
| private ArrayList<Point> points = new ArrayList<>(); |
Contributor
There was a problem hiding this comment.
points 변수를 생성하지 않고 구현해 본다.
points 변수가 없으면 Movement의 모든 메소드를 클래스 메소드로 구현할 수 있다.
모든 메소드를 클래스 메소드로 구현해 본다.
| private static final int MAX_NUM = 24; | ||
| private ArrayList<Point> points = new ArrayList<>(); | ||
|
|
||
| public ArrayList<Integer> axis() { |
Contributor
There was a problem hiding this comment.
ArrayList로 반환하지 말고 List로 구현해 본다.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
충돌 수동으로 처리 후 pr합니다.