Repository navigation
coordinate Step4 complete - #121
Merged
Merged
Conversation
javajigi
suggested changes
Oct 23, 2018
|
|
||
| public Rectangle(List<Point> points) { | ||
| this.points = points; | ||
| check(); |
Contributor
There was a problem hiding this comment.
check()를 먼저 한 후에 값을 할당하는 것이 낫지 않을까?
| int yCnt = 0; | ||
| int check = 0; | ||
| for (Point point : points) { | ||
| check += cntCoordinateValue(xCnt, yCnt, point); |
Contributor
There was a problem hiding this comment.
굳이 xCnt, yCnt 로컬 변수 생성하지 말고 cntCoordinateValue(0, 0, point); 구현하는 것은 어떤가?
| private List<Point> points; | ||
|
|
||
| public double getLength(List<Point> points) { | ||
| public Line(List<Point> points) { |
Contributor
There was a problem hiding this comment.
points.size()가 2인지 체크해야 하지 않을까?
|
|
||
| private List<Point> points; | ||
|
|
||
| public Rectangle(List<Point> points) { |
Contributor
There was a problem hiding this comment.
points.size()가 4인지 체크해야 하지 않을까?
|
|
||
| private List<Point> points; | ||
|
|
||
| public Triangle(List<Point> points) { |
Contributor
There was a problem hiding this comment.
points.size()가 3인지 체크해야 하지 않을까?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
step3,4 동시에 진행 하라고 하셔서, step4까지 완료 후 pr했습니다.