Skip to content

Step3 구현 - #102

Merged
javajigi merged 2 commits into
code-squad:jar100from
jar100:step3
Oct 12, 2018
Merged

javajigi merged 2 commits into
code-squad:jar100from
jar100:step3

Conversation

@jar100

@jar100 jar100 commented Oct 12, 2018

Copy link
Copy Markdown

강의시간에 if 와 switch 를 사용하지말고 구현해 보라고 한걸 듣고 미리 hashMap으로 rectangle과 line 중 선택해 출력하게 구현 해봤습니다.

@javajigi javajigi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현 잘 했네요. 👍
객체도 잘 활용했고요. 소소한 피드백 남겼으니 다음 단계에서 해결해 보세요.

if (this.xPoint == point.xPoint) {
return true;
}
return false;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return this.xPoint == point.xPoint;과 같이 구현 가능함.
Y도 같음

public void toDo(ArrayList<Point> points) {
HashMap<Integer, String> toDo = new HashMap<>();
toDo.put(TWO, new Line(points).calculate());
toDo.put(FOUR, new Rectangle(points).calculate());

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현 잘 했네요. 👍

@javajigi
javajigi merged commit a79857f into code-squad:jar100 Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants