Repository navigation
[볼링 게임] Step1 & Step2 - #98
Merged
Merged
Conversation
Contributor
|
View는 사용자가 콘솔 기반이냐, 웹 기반이냐이기 때문에 main() 메소드를 가지는 ConsoleApplication.java & WebApplication.java 두 개의 클래스 기반으로 구현하는 것이 맞을 것 같아요. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
안녕하세요 재성님
볼링게임 Step1 & Step2 코드리뷰 부탁드립니다 :)
작업하며 신경 쓴 부분은 아래와 같습니다.
한가지 질문 드리고 싶은 부분은.
현재 구조는 Application Service인 BowlingGame.java에서 View에 의존성을 가지고 있습니다.
좋은 방법 같진 않아 보이는데,
물론 해당 위치에서 View 구현체에 강결합을 가지는 것 보다
인터페이스로 접근하면 조금 더 나을 텐데 Web 쪽 인터페이스를 아직 확인하지 못한 터라, 인터페이스로 추출하기에도 망설여 지네요.
ConsoleApplication.java & WebApplication.java와 같이 View에 대한 구분을 Endpoint에서 하는게 가장 좋은 방법인지 궁금합니다. 감사합니다!