[pull] main from Comcast:main - #230
Merged
Merged
Conversation
* Migrate from ESLint to oxlint Replace ESLint with oxlint for JS/TS linting, keeping ESLint only for markdown (`@eslint/markdown` uses ESLint's language plugin API, which oxlint does not support). `.oxlintrc.json` was generated by `@oxlint/migrate --type-aware --with-nursery` and carries over 545 rules at their original `warn` severity. `@eslint-react` and `sonarjs` are loaded as `jsPlugins`; `typescript`, `react` and `vitest` use oxlint's native implementations, so `typescript-eslint`, `eslint-plugin-react-hooks` and `@vitest/eslint-plugin` are no longer needed. Rules that could not be migrated: - the 13 React Compiler rules (`react-hooks/purity`, `preserve-manual-memoization`, …) — oxlint only ships these as an experimental bundled `react/react-compiler` rule - `@eslint-react/no-implicit-key`, `no-leaked-conditional-rendering` and `no-unused-props` — oxlint's JS plugin API cannot supply parser services, so these throw on every file - `@typescript-eslint/naming-convention`, `prefer-destructuring`, `no-unused-private-class-members`, `require-atomic-updates`, `one-var` Three suppressions were added for behavioural differences rather than real defects: `sonarjs/no-redundant-optional` cannot see `exactOptionalPropertyTypes` without type information, and `vitest/no-conditional-expect` flags a helper that is not a test block. The existing directive in `globals.d.ts` moved down a line because oxlint reports the index signature where ESLint reported the interface. `@eslint-react/component-hook-factories` was dropped: it does not exist in that plugin and was silently ignored by ESLint because it was `off`. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> * remove references to .agents * yaml tweaks * fix double lint * settings tweaks * tweak eslint usage * disallow br * add CLAUDE.md symlink * re-enable typeAware * enable typeCheck * symlink -> file * nude sonarjs * tweak settings * tweak rules * fix CLAUDE.md * sort rules * review * use default categories settings * npm dedupe * npm audit fix * update packages, use ^ * couple tweaks --------- Co-authored-by: Claude Opus 5 (1M context) <[email protected]>
configure oxc rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )