Fix useminPrepare task to rewrite relative CSS urls - #1
Open
jridgewell wants to merge 1 commit into
Open
Conversation
First, tell useminPrepare to only 'cssmin' our CSS files (dropping the concat task). See yeoman/grunt-usemin#225. Second, tell cssmin to rewrite relative urls to be relative to our app directory. This is particularly useful for bower install components that have CSS files that reference relative urls. ie. ``` . ├── app │ └── bower_components │ └── component │ ├── images │ │ └── image.png │ └── style.css └── build ``` ``` body { background: url('images/image.png'); } ``` Will have now properly rewrite it's image url to ``` body { background: url('bower_components/component/images/image.png'); } ```
Author
There was a problem hiding this comment.
Removing a % would cause this line to be parsed while creating the app. See, for example, Lines 225-228
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, tell useminPrepare to only 'cssmin' our CSS files (dropping the
concat task). See yeoman/grunt-usemin#225.
Second, tell cssmin to rewrite relative urls to be relative to our app
directory.
This is particularly useful for bower install components that have CSS
files that reference relative urls. ie.
Will have now properly rewrite it's image url to