Conversation
Clean PGDATA and a separate PGWAL directory whenever backup recovery fails, including PostgreSQL WAL replay failures that are not represented by CloudRestoreError. This prevents failed Job attempts from accumulating restored data on the PVC. Signed-off-by: opplion <[email protected]>
cnpg-bot
added
backport-requested ◀️
Contributor
|
❗ By default, the pull request is configured to backport to all release branches.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backup recovery can fail after the base backup has been extracted, for example when PostgreSQL detects a WAL gap. These errors are not
CloudRestoreErrorvalues, so the existing cleanup is skipped. On Kubernetes Job retries, the leftoverPGDATAis preserved and another base backup is extracted, eventually filling the PVC.PGDATAafter everyRestorefailurePGWALtarget when configuredFixes cloudnative-pg/plugin-barman-cloud#1100
Testing
go test ./internal/cmd/manager/instance/restorego test ./internal/cmd/manager/instance/...go test ./pkg/management/postgresgo vet ./internal/cmd/manager/instance/restore